CLDC-3788 Export sales logs #2943
Conversation
|
Created review app at https://review.submit-social-housing-data.communities.gov.uk/2943 |
| csv: 2, | ||
| }.freeze | ||
|
|
||
| EXPORT_FIELDS = Set["id", |
There was a problem hiding this comment.
Do we have a final fields list?
Rachel mentioned on the ticket she was adding mrentprestaircasing which I don't see here.
I also wonder whether we might be missing another couple of fields, by my count this is 123 fields +18+5 = 146 fields, compared to 148 on the spreadsheet on the ticket (which doesn't include mrentprestaircasing). Is this the service charge fields?
| pregyrha { 1 } | ||
| pregla { 1 } | ||
| pregother { 1 } | ||
| pregghb { 1 } |
There was a problem hiding this comment.
I don't think we have these in 2025 (and we don't export sales logs from 2024 or earlier, so I think we can remove these)
| @@ -23,7 +25,7 @@ | |||
| Timecop.return | |||
| end | |||
|
|
|||
| context "when exporting daily XMLs" do | |||
| context "when exporting daily XMLs before 2025" do | |||
There was a problem hiding this comment.
Should we move the let(:start_time) from line 8 here?
| context "when exporting daily XMLs" do | ||
| context "and no sales archives get created in sales logs export" do | ||
| let(:sales_logs_export_service) { instance_double("Exports::SalesLogExportService", export_xml_sales_logs: {}) } | ||
| let(:lettings_logs_export_service) { instance_double("Exports::LettingsLogExportService", export_xml_lettings_logs: {}) } |
There was a problem hiding this comment.
This is already set on line 397 right?
No description provided.