diff --git a/cla-backend-go/cmd/functional_tests/approval_list/approval_list.go b/cla-backend-go/cmd/functional_tests/approval_list/approval_list.go index e8a51bc91..f63879840 100644 --- a/cla-backend-go/cmd/functional_tests/approval_list/approval_list.go +++ b/cla-backend-go/cmd/functional_tests/approval_list/approval_list.go @@ -308,7 +308,6 @@ func (t *TestBehaviour) RunUpdateApprovalListAddEmail(testData InputTestValues) ExpectJsonType("signatureType", reflect.String). ExpectJsonType("signatureApproved", reflect.Bool). ExpectJsonType("signatureSigned", reflect.Bool). - // ExpectJsonType("signatureEmbargoAcked", reflect.Bool). ExpectJsonType("signatureCreated", reflect.String). ExpectJsonType("signatureModified", reflect.String). ExpectJsonType("version", reflect.String). @@ -353,7 +352,6 @@ func (t *TestBehaviour) RunUpdateApprovalListRemoveEmail(testData InputTestValue ExpectJsonType("signatureType", reflect.String). ExpectJsonType("signatureApproved", reflect.Bool). ExpectJsonType("signatureSigned", reflect.Bool). - // ExpectJsonType("signatureEmbargoAcked", reflect.Bool). ExpectJsonType("signatureCreated", reflect.String). ExpectJsonType("signatureModified", reflect.String). ExpectJsonType("version", reflect.String). @@ -398,7 +396,6 @@ func (t *TestBehaviour) RunUpdateApprovalListAddDomain(testData InputTestValues) ExpectJsonType("signatureType", reflect.String). ExpectJsonType("signatureApproved", reflect.Bool). ExpectJsonType("signatureSigned", reflect.Bool). - // ExpectJsonType("signatureEmbargoAcked", reflect.Bool). ExpectJsonType("signatureCreated", reflect.String). ExpectJsonType("signatureModified", reflect.String). ExpectJsonType("version", reflect.String). @@ -443,7 +440,6 @@ func (t *TestBehaviour) RunUpdateApprovalListRemoveDomain(testData InputTestValu ExpectJsonType("signatureType", reflect.String). ExpectJsonType("signatureApproved", reflect.Bool). ExpectJsonType("signatureSigned", reflect.Bool). - // ExpectJsonType("signatureEmbargoAcked", reflect.Bool). ExpectJsonType("signatureCreated", reflect.String). ExpectJsonType("signatureModified", reflect.String). ExpectJsonType("version", reflect.String). @@ -488,7 +484,6 @@ func (t *TestBehaviour) RunUpdateApprovalListAddGitHubUsername(testData InputTes ExpectJsonType("signatureType", reflect.String). ExpectJsonType("signatureApproved", reflect.Bool). ExpectJsonType("signatureSigned", reflect.Bool). - // ExpectJsonType("signatureEmbargoAcked", reflect.Bool). ExpectJsonType("signatureCreated", reflect.String). ExpectJsonType("signatureModified", reflect.String). ExpectJsonType("version", reflect.String). @@ -533,7 +528,6 @@ func (t *TestBehaviour) RunUpdateApprovalListRemoveGitHubUsername(testData Input ExpectJsonType("signatureType", reflect.String). ExpectJsonType("signatureApproved", reflect.Bool). ExpectJsonType("signatureSigned", reflect.Bool). - // ExpectJsonType("signatureEmbargoAcked", reflect.Bool). ExpectJsonType("signatureCreated", reflect.String). ExpectJsonType("signatureModified", reflect.String). ExpectJsonType("version", reflect.String). @@ -578,7 +572,6 @@ func (t *TestBehaviour) RunUpdateApprovalListAddGitHubOrg(testData InputTestValu ExpectJsonType("signatureType", reflect.String). ExpectJsonType("signatureApproved", reflect.Bool). ExpectJsonType("signatureSigned", reflect.Bool). - // ExpectJsonType("signatureEmbargoAcked", reflect.Bool). ExpectJsonType("signatureCreated", reflect.String). ExpectJsonType("signatureModified", reflect.String). ExpectJsonType("version", reflect.String). @@ -623,7 +616,6 @@ func (t *TestBehaviour) RunUpdateApprovalListRemoveGitHubOrg(testData InputTestV ExpectJsonType("signatureType", reflect.String). ExpectJsonType("signatureApproved", reflect.Bool). ExpectJsonType("signatureSigned", reflect.Bool). - // ExpectJsonType("signatureEmbargoAcked", reflect.Bool). ExpectJsonType("signatureCreated", reflect.String). ExpectJsonType("signatureModified", reflect.String). ExpectJsonType("version", reflect.String). diff --git a/cla-backend-go/cmd/functional_tests/cla_manager/cla_manager.go b/cla-backend-go/cmd/functional_tests/cla_manager/cla_manager.go index 787979997..ec71d9dac 100644 --- a/cla-backend-go/cmd/functional_tests/cla_manager/cla_manager.go +++ b/cla-backend-go/cmd/functional_tests/cla_manager/cla_manager.go @@ -472,7 +472,6 @@ func (t *TestBehaviour) RunAddCLAManager() { ExpectJsonType("signatureModified", reflect.String). ExpectJsonType("signatureSigned", reflect.Bool). ExpectJsonType("signatureApproved", reflect.Bool). - // ExpectJsonType("signatureEmbargoAcked", reflect.Bool). ExpectJsonType("signatureReferenceType", reflect.String). ExpectJsonType("signatureReferenceID", reflect.String). ExpectJsonType("signatureReferenceName", reflect.String). @@ -541,7 +540,6 @@ func (t *TestBehaviour) RunRemoveCLAManager() { ExpectJsonType("signatureModified", reflect.String). ExpectJsonType("signatureSigned", reflect.Bool). ExpectJsonType("signatureApproved", reflect.Bool). - // ExpectJsonType("signatureEmbargoAcked", reflect.Bool). ExpectJsonType("signatureReferenceType", reflect.String). ExpectJsonType("signatureReferenceID", reflect.String). ExpectJsonType("signatureReferenceName", reflect.String). diff --git a/cla-backend-go/swagger/common/corporate-contributor.yaml b/cla-backend-go/swagger/common/corporate-contributor.yaml index 9e6425306..24e35b46c 100644 --- a/cla-backend-go/swagger/common/corporate-contributor.yaml +++ b/cla-backend-go/swagger/common/corporate-contributor.yaml @@ -48,8 +48,3 @@ properties: type: boolean description: the flag for contributor that has not yet been approved x-omitempty: false -# signatureEmbargoAcked: -# type: boolean -# description: the signature embargo acknowledged flag - true or false value -# example: true -# # x-omitempty: false