-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: initial testing setup #41
Conversation
This is probably related to GitHub Actions permissions somehow... I feel like it should be able to create that branch? I can't remember what we did in the past, but I'm pretty sure I never created the branch by hand. The docs say
There's also this note in the docs: https://github.com/py-cov-action/python-coverage-comment-action?tab=readme-ov-file#setup
|
8e10c9e
to
9f8ab8f
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
Ah, I had forgotten to configure |
implements the healthcheck as a middleware before the HOST_HEADER verification (in django.middleware.common.CommonMiddleware), so healthcheck requests always pass based on https://stackoverflow.com/a/64623669
- sets Python version for GitHub workflows - adds workflow and shell script that runs pytest
this is needed since we don't want to allow unit tests to go out to the internet
9f8ab8f
to
2a5a061
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I was able to run the tests locally in the devcontainer too.
Closes #6
This PR
/healthcheck
endpoint from the app and asserts a 200 response code and "Healthy" response text. The endpoint is implemented as Django middleware.ThePytest
workflow is failing probably due to a pendingpython-coverage-comment-action-data
branch.