A fix to processing entries for zenodo, print ORCID URL in interactive mode, perform some internal code refactorings #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So instead of
INFO:github:Alejandro de la Vega: found more than 1 result, run with --interactive mode to select.
INFO:github:Alejandro de la Vega: found more than 1 result, run with --interactive mode to select.
INFO:github:Alejandro de la Vega: found more than 1 result, run with --interactive mode to select.
we get
INFO:github:Alejandro de la Vega: found more than 1 (186) result for ORCID search by name, run with --interactive mode to select.
INFO:github:Alejandro de la Vega: found more than 1 (1000) result for ORCID search by name without middle, run with --interactive mode to select.
INFO:github:Alejandro de la Vega: found more than 1 (1000) result for ORCID search full name, run with --interactive mode to select.
(disregard that there is no middle name here... separate issue)
I think it does not change any result but IMHO should be more Kosher
…not orcid_id" conditioning
…o ease checking full record
…: just use min) Without this fix I could not enter the last choice index
It now should work also disregarding explicitly specified to be null or empty ORCID entries or values for name or affiliation which people might explicitly white out in a specific case. Before it was solely based on the presence of the key and I think making it more value based would be more robust. Also dictionary comprehension for lookup generation should be easier to read IMHO, and the code simplifications/reduction of [][] lookups also should be making it easier to read. Also may be it is just an anecdotal evidence and just coincided, but with this code we got one more affiliation assigned in datalad case right after prior run http://github.com/datalad/datalad/commit/ffc008b67c0596c16dadd7daeb58204a010ece74
vsoch
reviewed
Jun 7, 2023
tributors/main/orcid.py
Outdated
| @@ -129,7 +130,7 @@ def get_orcid_token(): | |||
| return orcid_token | |||
|
|
|||
|
|
|||
| def record_search(url, email, interactive=False): | |||
| def record_search(url, email, interactive=False, how=""): | |||
There was a problem hiding this comment.
I can tell what "how" is based on reading below how the functions are using it - can we use a more descriptive label here, like search type, and document this in the docstring so it's clear the string is just for informational purposes and doesn't derive any logic?
vsoch
reviewed
Jun 7, 2023
yarikoptic
changed the title
I have merged #74, so hopefully it all would just get released when we merge it. I added |
|
Hmm that approach seems super complex compared to what I usually do, but if you are managing it I’m indifferent. LGTM merge and release as you like. |
Initial setup is indeed a bit "complex" but whenever it works - it can't be simpler, just
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One commit addresses #77 (has proper Closes). Individual commits have description on the changes so best to review one commit at a time.