Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json_struct receipt #25335

Merged
merged 4 commits into from
Nov 28, 2024
Merged

json_struct receipt #25335

merged 4 commits into from
Nov 28, 2024

Conversation

jorgen
Copy link
Contributor

@jorgen jorgen commented Sep 19, 2024

Summary

Add recipe: json_struct/1.0.1

Motivation

Adding the json_struct header only library

Details

json_struct is a single header only library that parses JSON to C++ structs/classes and serializing structs/classes to JSON.


@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Sep 20, 2024
@AbrilRBS
Copy link
Member

Hi @jorgen thanks a lot for taking the time to add the recipe. There are some easy changes to make it more compliant with CCI policies, could you check the package template in https://github.com/conan-io/conan-center-index/blob/master/docs/package_templates/header_only/all/conanfile.py and follow it? It would help tremendously, thanks! :)

@jorgen
Copy link
Contributor Author

jorgen commented Sep 23, 2024

Ok, I have trimmed it down. How does it look?

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 8 (a52206423d7dbb6d0f76e741450bb9b323b67aa2):

  • json_struct/1.0.2:
    Error running command conan info json_struct/1.0.2@#afa974d14538b6c7952b20d95ef38828 --json {jsonName} --dry-build -pr {profileName}:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    
    ...
    ERROR: json_struct/1.0.2: Error in validate() method, line 40
    	compiler_version = self._min_compiler_versions.get(str(self.settings.compiler))
    	AttributeError: 'JsonStructConan' object has no attribute '_min_compiler_versions'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Failure in build 8 (a52206423d7dbb6d0f76e741450bb9b323b67aa2):

  • json_struct/1.0.2:
    Error running command conan graph info --requires json_struct/1.0.2@#afa974d14538b6c7952b20d95ef38828 --build json_struct/1.0.2@#afa974d14538b6c7952b20d95ef38828 -f json -pr:h /home/conan/workspace/prod-v2/bsr/89505/cbabb/profile_linux_11_libstdcpp11_17_gcc_release_64..txt -pr:b /home/conan/workspace/prod-v2/bsr/89505/cbabb/profile_linux_11_libstdcpp11_17_gcc_release_64..txt:
    ======== Computing dependency graph ========
    Graph root
        cli
    Requirements
        json_struct/1.0.2#afa974d14538b6c7952b20d95ef38828 - Cache
    
    ======== Computing necessary packages ========
    ERROR: json_struct/1.0.2: Error in validate() method, line 40
    	compiler_version = self._min_compiler_versions.get(str(self.settings.compiler))
    	AttributeError: 'JsonStructConan' object has no attribute '_min_compiler_versions'
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@AbrilRBS
Copy link
Member

Hi @jorgen sorry for the delay on getting this reviewed, we were focused on launching the new CI system so some PRs got delayed - hopefuly the new experience is worth it. I've now pushed some last cleanups, and other once it compiles I'll push to get this merged.

Thanks again for taking the time to add this to CCI, we appreciate it

(For future traceability: 1.0.2 seems to have been tagged but not released, but I'm approving as-is, the diff is only for the cmake min version)

Copy link
Contributor

@perseoGI perseoGI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@perseoGI perseoGI merged commit 4b0aa3d into conan-io:master Nov 28, 2024
7 checks passed
@jorgen
Copy link
Contributor Author

jorgen commented Nov 28, 2024

@AbrilRBS thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants