-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
json_struct receipt #25335
json_struct receipt #25335
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @jorgen thanks a lot for taking the time to add the recipe. There are some easy changes to make it more compliant with CCI policies, could you check the package template in https://github.com/conan-io/conan-center-index/blob/master/docs/package_templates/header_only/all/conanfile.py and follow it? It would help tremendously, thanks! :) |
Ok, I have trimmed it down. How does it look? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ❌Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hi @jorgen sorry for the delay on getting this reviewed, we were focused on launching the new CI system so some PRs got delayed - hopefuly the new experience is worth it. I've now pushed some last cleanups, and other once it compiles I'll push to get this merged. Thanks again for taking the time to add this to CCI, we appreciate it (For future traceability: 1.0.2 seems to have been tagged but not released, but I'm approving as-is, the diff is only for the cmake min version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@AbrilRBS thank you! |
Summary
Add recipe: json_struct/1.0.1
Motivation
Adding the json_struct header only library
Details
json_struct is a single header only library that parses JSON to C++ structs/classes and serializing structs/classes to JSON.