This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
use robocopy instead of native copy on Windows #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this moves the naive volume driver's 'robocopy' usage to the 'copy' package and then switches the naive driver to just use the 'copy' package. bonus: use /mt for multithreaded copy - way faster! Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
nothing calls this anymore now that Windows uses robocopy. it's basically always better to just shell out. Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
the overlay tests would only pass if the image was fetched on another worker and then streamed to the worker that runs the tests, which would result in / being ext4 (or whatever the host filesystem is). if the image was already present on the worker, it'd be a copy-on-right volume, which would result in / (and thus /tmp) being overlay, so the overlay tests failing with 'invalid argument' and a dmesg error saying the filesystem is not supported. Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
taylorsilva
approved these changes
Feb 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cp(Linux, Darwin) orrobocopy(Windows)/mtflag torobocopy(multithreaded copy - wicked fast!)