Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also test for charconv library #206

Merged
merged 2 commits into from
May 14, 2024

Conversation

sdebionne
Copy link
Contributor

@sdebionne sdebionne commented May 14, 2024

Adding charconv to the list of build libraries.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title is a bit misleading. The only place where we're "adding" charconv is in testing that the required (shared) libraries are there at the end of the build.

This can be seen also since the 1.85 from #196 were failing specifically in charconv already before this PR (and the patch to fix it). Long story short, this is a reasonable test improvement, but not worth a separate build (so we can just leave the build number as-is).

recipe/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: h-vetinari <h.vetinari@gmx.com>
@h-vetinari h-vetinari changed the title Add charconv library also test for charconv library May 14, 2024
@h-vetinari h-vetinari merged commit cff257d into conda-forge:main May 14, 2024
8 checks passed
@sdebionne sdebionne deleted the add-charconv-library branch May 15, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants