-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCC 12 & LLVM 15 #4215
GCC 12 & LLVM 15 #4215
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me, leaving open for others to review.
Since opening this PR, I found out there's something happening in conda-forge/llvmdev-feedstock#201 (as well as the |
This should be fixed now (at least enough to not block the compiler bump, IMO) - thanks @isuruf! |
With conda-forge/clang-compiler-activation-feedstock#99 merged, we'd also have clang 16.0.0 available now, but I'd propose to let the dust settle on this a bit longer (e.g. 2-3 patch releases) before we make the switch. 15 should be good to go though. |
Are there current know issues with the transition? We seem to be hitting some challenges with libcxx conda-forge/qt-main-feedstock#136 (comment) |
None that I'm aware of. It's a bog-standard compiler version bump, nothing of substance should change, except of course the usual feature work, performance improvement, bug fixes etc.
This is the fallout of the removal of a long-deprecated facility and therefore nothing unusual. I've commented there for available workarounds, but it's not an indication of problems in the stack. |
So far this has two acks from core and no opposition (also not counting the additional 2 voices in support of moving to GCC 12 in #3731). Anything else that needs doing/discussing here @conda-forge/core? |
Something I wasn't aware of for the to-do list before the next GCC bump: ensure that https://github.com/conda-forge/gfortran_osx-64-feedstock & https://github.com/conda-forge/gfortran_impl_osx-64-feedstock are up to date |
Should we add this to the conda-forge docs somewhere? |
Only that's highly outdated 😅 |
I can try to write something. |
Great! It is good to keep historical information present in those docs though. |
Done: conda-forge/conda-forge.github.io#1946
Well have to hash that out in the PR. I think text that describes a world based on the constraints of |
Yeah this is a good point. Some maintainers want to be able to chip in, but need terse relevant info The historical info is useful from a diagnosing odd behavior (or understanding the decisions made) perspective and maybe should be a separate section How do other projects approach this separation of concerns? |
Now that LLVM 15 has been finally made it to conda-forge (bits and pieces have been floating around for half a year, but we were missing some things to enable it), we could now upgrade (c.f. #2010 / #3290).
Already for #3731, a lot of people wanted to jump straight to GCC 12, so this should not be hugely controversial. If people want to wait some more for LLVM 15, I can split off the GCC changes into a separate PR.
Sidenote: LLVM 16 release is imminent (this time, the builds in conda-forge are basically ready 🥳), and GCC 13 is expected in April/May.
PS. Like for #3731, we can't use newer GCC together with CUDA 11.x compilers.