New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop supporting v11 #57

Closed

traversaro wants to merge 2 commits into conda-forge:main from traversaro:eoledifice

Contributor

traversaro commented Apr 8, 2022 •

edited

Loading

It just reached end of life, see gazebo-tooling/release-tools#655 .

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

@conda-forge-admin, please rerender

traversaro added 2 commits

April 8, 2022 18:45


          Update meta.yaml

6b71b75


          Update conda-forge.yml

b83730f

traversaro requested review from Tobias-Fischer, a team, j-rivero and seanyen as code owners

April 8, 2022 16:46

conda-forge-linter commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Contributor Author

traversaro commented Apr 8, 2022

@conda-forge-admin, please rerender

Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116437215.

Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116437384.

Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116437513.

Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116437673.

Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116437440.

Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116438861.

Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116440372.

Contributor

github-actions bot commented Apr 8, 2022

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libsdformat-feedstock/actions/runs/2116440455.

Contributor

Tobias-Fischer commented Apr 8, 2022

This is still being used in robostack. Do we know if ROS supports newer versions without issues?

Contributor Author

traversaro commented Apr 8, 2022

This is still being used in robostack. Do we know if ROS supports newer versions without issues?

Interesting, I had no idea. The original repo is using sdformat9 (the one used in Gazebo Classic) , any idea why we patch it to use sdformat11 in https://github.com/RoboStack/ros-galactic/blob/9a8356042c270b69f77f2d8ef341ed807d3e5ea4/patch/ros-galactic-sdformat-urdf.patch instead?

Contributor

Tobias-Fischer commented Apr 9, 2022

I think because the ignition libraries that are pulled in (https://github.com/RoboStack/ros-noetic/blob/e5a20fca7f3882c9713460ab593d8ba826abc6ee/conda.yaml#L140-L159) only work with sdformat11?!? But I could be totally wrong.

traversaro mentioned this pull request

In Galactic sdformat points to sdformat9, i.e. libsdformat conda-forge package RoboStack/ros-galactic#100

Open

Contributor Author

traversaro commented Jun 6, 2023

@Tobias-Fischer I guess we can go on with this now that all the effort on robostack has been moved to humble, right?

Contributor

Tobias-Fischer commented Jun 6, 2023

Hmmm, ideally we would like to support Noetic for a little while - this is a big attraction of RoboStack. I’m not sure if we can move Noetic to newer versions though?

Contributor Author

traversaro commented Jun 6, 2023 •

edited

Loading

Hmmm, ideally we would like to support Noetic for a little while - this is a big attraction of RoboStack. I’m not sure if we can move Noetic to newer versions though?

Noetic uses libsdformat package, i.e. sdformat9 (see https://github.com/RoboStack/ros-noetic/blob/e4c4e41afa60975a260dfe0ab2ebce25e11993b9/robostack.yaml#L833). What I want to drop support for is sdformat11 .

Contributor

Tobias-Fischer commented Jun 6, 2023

Ah apologies, I should have read the whole issue before replying. All good with me, happy to stop the support for v11

traversaro closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Tobias-Fischer Awaiting requested review from Tobias-Fischer Tobias-Fischer is a code owner

j-rivero Awaiting requested review from j-rivero j-rivero is a code owner

seanyen Awaiting requested review from seanyen seanyen is a code owner

Labels

None yet