Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 18.1.0 #24

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Update to 18.1.0 #24

merged 7 commits into from
Jun 5, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented May 31, 2024

Update was blocked because spirv-headers stopped updating. Now, that conda-forge/spirv-headers-feedstock#15 is merged, the update should be unblocked.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes: #19
Fixes: #22

I want to target #23 after KhronosGroup/SPIRV-LLVM-Translator#2586 is merged

UPD

Block was also due to new abi version by llvm that blocked testing/file picking.

UPD2

From build log:

-- SPIRV-Tools not found; project will be built without --spirv-tools-dis support.

So spirv-tools must be added to meet this functionality. Thankfully this is only binary dependency, not library one.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@ZzEeKkAa
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ZzEeKkAa ZzEeKkAa changed the title Update/release18.1.0 Update to 18.1.0 Jun 1, 2024
@ZzEeKkAa
Copy link
Contributor Author

ZzEeKkAa commented Jun 3, 2024

@isuruf could you review it, please?

@ZzEeKkAa
Copy link
Contributor Author

ZzEeKkAa commented Jun 4, 2024

@isuruf @matthiasdiener are there anything to be done before merging this PR?

@ZzEeKkAa ZzEeKkAa mentioned this pull request Jun 5, 2024
5 tasks
@isuruf isuruf merged commit 1640965 into conda-forge:main Jun 5, 2024
7 checks passed
@isuruf
Copy link
Member

isuruf commented Jun 5, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants