Add env variable and pre kernel launch logic
#40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimergp
requested changes
Oct 28, 2022
There was a problem hiding this comment.
Some comments about the logic!
- We are going to call it
pre_condabecause it'll run before conda is initialized. - The pre_conda contents can contain environment variables and/or the shell script. So no need to check for both at the same time, since we can have none, either or both!
Once we have these modifications, we can run the tests. Thanks!
jaimergp
reviewed
Nov 1, 2022
jaimergp
reviewed
Nov 1, 2022
jaimergp
reviewed
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we are providing the ability to set environment variables and add a bash script to run before activating the conda base environment.
Closes #39
You can check this example notebook demonstrating the new feature here.
Status