Render post-install pages for Windows when input is a string #904

marcoesters · 2024-11-25T22:20:24Z

Windows assumed that post_install_pages is a list, but can also be a string. This PR fixes this.

Add a file to the news directory (using the template) for the next release's release notes?
Add / update necessary tests?
Add / update outdated documentation?

tests/test_examples.py

marcoesters added 3 commits November 25, 2024 14:04

Render post-install pages for Windows when input is a string

c6b4b16

Add news

27bfa62

Update Windows extra page test

7ff7f7c

conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Nov 25, 2024

marcoesters added 3 commits November 25, 2024 14:28

Fix typo

d971190

Fix parametrize syntax

5614ce7

Remove post_install_pages from base example

f088d7c

marcoesters marked this pull request as ready for review November 25, 2024 23:39

marcoesters requested a review from a team as a code owner November 25, 2024 23:39

jaimergp reviewed Nov 26, 2024

View reviewed changes

tests/test_examples.py Outdated Show resolved Hide resolved

Use jinja in extra page example

881305e

marcoesters requested a review from jaimergp November 26, 2024 15:42

jaimergp approved these changes Nov 28, 2024

View reviewed changes

jaimergp merged commit d85133d into conda:main Nov 28, 2024
18 checks passed

marcoesters deleted the extra-pages-list branch December 2, 2024 15:21

Provide feedback