diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index af957c5a7..45518e0a2 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -105,6 +105,7 @@ jobs: && files+=(--file "dev/extra-requirements-${{ runner.os }}.txt") conda install ${files[@]} -y echo "NSIS_USING_LOG_BUILD=1" >> $GITHUB_ENV + echo "NSIS_SCRIPTS_RAISE_ERRORS=1" >> $GITHUB_ENV pip install -e . --no-deps --no-build-isolation - name: Set up conda executable run: | diff --git a/constructor/nsis/main.nsi.tmpl b/constructor/nsis/main.nsi.tmpl index b6caa495e..030b4cc00 100644 --- a/constructor/nsis/main.nsi.tmpl +++ b/constructor/nsis/main.nsi.tmpl @@ -1265,7 +1265,7 @@ Section "Install" File {{ conda_exe }} File {{ pre_uninstall }} -{%- for path, files in extra_files | items %} +{%- for path, files in EXTRA_FILES | items %} SetOutPath {{ path }} {%- for file in files %} File {{ file }} diff --git a/news/942-fix-win-extra_files b/news/942-fix-win-extra_files new file mode 100644 index 000000000..2e539a8aa --- /dev/null +++ b/news/942-fix-win-extra_files @@ -0,0 +1,19 @@ +### Enhancements + +* + +### Bug fixes + +* Fix `extra_files` functionality on EXE installers. (#942) + +### Deprecations + +* + +### Docs + +* + +### Other + +*