Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all: migrate from k8s.gcr.io to registry.k8s.io #621

Merged
merged 1 commit into from
Feb 22, 2023
Merged

all: migrate from k8s.gcr.io to registry.k8s.io #621

merged 1 commit into from
Feb 22, 2023

Conversation

CIPHERTron
Copy link
Contributor

This fix is a part of an umbrella issue kubernetes/k8s.io#4780

snir911
snir911 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@snir911 snir911 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, LGTM overall
nit, if you don't mind please add Fixes: kubernetes/k8s.io#4780 to the commit msg for reference (also very nit-i think all: would fit better than fix:)

@CIPHERTron
Fixes: kubernetes/k8s.io#4780
3f2bb6c 
Signed-off-by: CIPHERTron <pritish.samal918@gmail.com>
@CIPHERTron CIPHERTron changed the title fix: migrate from k8s.gcr.io to registry.k8s.io all: migrate from k8s.gcr.io to registry.k8s.io Feb 22, 2023
@CIPHERTron
Copy link
Contributor Author

Thanks for the patch, LGTM overall nit, if you don't mind please add Fixes: kubernetes/k8s.io#4780 to the commit msg for reference (also very nit-i think all: would fit better than fix:)

@snir911 I've addressed your comments. PTAL. Thanks!

bpradipt
bpradipt approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@bpradipt bpradipt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @CIPHERTron

@bpradipt
Copy link
Member

Force merging this.

@bpradipt bpradipt merged commit e1d15e9 into confidential-containers:staging Feb 22, 2023
@mrbobbytables mrbobbytables mentioned this pull request Mar 7, 2023
Open
70 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snir911 snir911 snir911 approved these changes

@bpradipt bpradipt bpradipt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CIPHERTron @bpradipt @snir911