Changed property name to js.consumer.max.batch.size

Author: emasab

CHANGELOG.md

@@ -4,7 +4,7 @@ v1.6.1 is a maintenance release. It is supported for all usage.
 
 ### Enhancements
 
-1. Configurable batch size through the `js.max.batch.size` property (#389).
+1. Configurable batch size through the `js.consumer.max.batch.size` property (#389).
 
 
 # confluent-kafka-javascript 1.6.0

MIGRATION.md

@@ -304,7 +304,7 @@ producerRun().then(consumerRun).catch(console.error);
     Heartbeats are automatically managed by librdkafka.
   - The `partitionsConsumedConcurrently` is supported by both `eachMessage` and `eachBatch`.
   - An API compatible version of `eachBatch` is available, maximum batch size
-    can be configured through the `js.max.batch.size` configuration property
+    can be configured through the `js.consumer.max.batch.size` configuration property
     and defaults to 32.
     The property `eachBatchAutoResolve` is supported.
     Within the `eachBatch` callback, use of `uncommittedOffsets` is unsupported,

examples/performance/performance-primitives.js

@@ -151,7 +151,7 @@ function newCompatibleConsumer(parameters, eachBatch) {
         { 'enable.auto.commit': false };
     const jsOpts = {};
     if (eachBatch && CONSUMER_MAX_BATCH_SIZE !== null) {
-        jsOpts['js.max.batch.size'] = CONSUMER_MAX_BATCH_SIZE;
+        jsOpts['js.consumer.max.batch.size'] = CONSUMER_MAX_BATCH_SIZE;
     }
 
     let groupId = eachBatch ? process.env.GROUPID_BATCH : process.env.GROUPID_MESSAGE;

lib/kafkajs/_consumer.js

@@ -701,19 +701,19 @@ class Consumer {
     this.#cacheExpirationTimeoutMs = this.#maxPollIntervalMs;
     rdKafkaConfig['max.poll.interval.ms'] = this.#maxPollIntervalMs * 2;
 
-    if (rdKafkaConfig['js.max.batch.size'] !== undefined) {
-      const maxBatchSize = +rdKafkaConfig['js.max.batch.size'];
+    if (rdKafkaConfig['js.consumer.max.batch.size'] !== undefined) {
+      const maxBatchSize = +rdKafkaConfig['js.consumer.max.batch.size'];
       if (!Number.isInteger(maxBatchSize) || (maxBatchSize <= 0 && maxBatchSize !== -1)) {
         throw new error.KafkaJSError(
-          "'js.max.batch.size' must be a positive integer or -1 for unlimited batch size.",
+          "'js.consumer.max.batch.size' must be a positive integer or -1 for unlimited batch size.",
           { code: error.ErrorCodes.ERR__INVALID_ARG });
       }
       this.#maxBatchSize = maxBatchSize;
       this.#maxBatchesSize = maxBatchSize;
       if (maxBatchSize === -1) {
         this.#messageCacheMaxSize = Number.MAX_SAFE_INTEGER;
       }
-      delete rdKafkaConfig['js.max.batch.size'];
+      delete rdKafkaConfig['js.consumer.max.batch.size'];
     }
 
     return rdKafkaConfig;

lib/util.js

@@ -52,4 +52,4 @@ util.dictToStringList = function (mapOrObject) {
   return list;
 };
 
-util.bindingVersion = '1.6.1-alpha.0';
+util.bindingVersion = '1.6.1-alpha.1';

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@confluentinc/kafka-javascript",
-  "version": "1.6.1-alpha.0",
+  "version": "1.6.1-alpha.1",
   "description": "Node.js bindings for librdkafka",
   "librdkafka": "2.12.0",
   "librdkafka_win": "2.12.0",

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@confluentinc/schemaregistry",
-  "version": "1.6.1-alpha.0",
+  "version": "1.6.1-alpha.1",
   "description": "Node.js client for Confluent Schema Registry",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",

schemaregistry/package.json

@@ -251,7 +251,7 @@ export interface JSConsumerConfig {
    *
    * @default 32
    */
-  'js.max.batch.size'?: string | number
+  'js.consumer.max.batch.size'?: string | number
 }
 
 export type ConsumerGlobalAndTopicConfig = ConsumerGlobalConfig & ConsumerTopicConfig & JSConsumerConfig;