Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix order of param #1263

Merged
merged 1 commit into from
Feb 17, 2022
Merged

fix order of param #1263

merged 1 commit into from
Feb 17, 2022

Conversation

DLT1412
Copy link
Contributor

@DLT1412 DLT1412 commented Jan 13, 2022

In example, AvroDeserializer/Serializer init with wrong order of param. This PR fix it.

confluent-kafka-python/src/confluent_kafka/schema_registry/avro.py

Line 155 in d2667e9

def __init__(self, schema_registry_client, schema_str,

@edenhill
Copy link
Contributor

[clabot:check]

jliunyu
jliunyu approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@jliunyu jliunyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DLT1412, thanks for the contribute, the change looks good to me.

@jliunyu jliunyu merged commit e2a11bc into confluentinc:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jliunyu jliunyu jliunyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DLT1412 @edenhill @jliunyu