Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KIP-430] Added ACL Operations to Describe Topics, Cluster and ConsumerGroup APIs #1635

Merged
merged 32 commits into from
Oct 23, 2023
Merged

[KIP-430] Added ACL Operations to Describe Topics, Cluster and ConsumerGroup APIs #1635

merged 32 commits into from
Oct 23, 2023

Conversation

pranavrth
Copy link
Member

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Sep 5, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Sep 5, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@pranavrth pranavrth marked this pull request as ready for review September 11, 2023 08:01
@pranavrth pranavrth requested a review from a team as a code owner September 11, 2023 08:01
@pranavrth pranavrth requested a review from emasab September 11, 2023 08:02
@pranavrth pranavrth mentioned this pull request Sep 11, 2023
Closed
emasab
emasab requested changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pranav. First comments.

examples/adminapi.py Show resolved Hide resolved
src/confluent_kafka/admin/_topic.py Outdated Show resolved Hide resolved
src/confluent_kafka/admin/_cluster.py Outdated Show resolved Hide resolved
src/confluent_kafka/_model/__init__.py Outdated Show resolved Hide resolved
src/confluent_kafka/admin/__init__.py Outdated Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Outdated Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Outdated Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Outdated Show resolved Hide resolved
src/confluent_kafka/src/confluent_kafka.c Show resolved Hide resolved
src/confluent_kafka/_model/__init__.py Show resolved Hide resolved
emasab
emasab requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments focused mainly on tests, examples and optional fields

tests/integration/admin/test_descibe_operations.py Outdated Show resolved Hide resolved
tests/integration/admin/test_descibe_operations.py Outdated Show resolved Hide resolved
tests/integration/admin/test_descibe_operations.py Outdated Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Outdated Show resolved Hide resolved
examples/adminapi.py Outdated Show resolved Hide resolved
examples/adminapi.py Outdated Show resolved Hide resolved
src/confluent_kafka/src/Admin.c Outdated Show resolved Hide resolved
@emasab
Copy link
Contributor

emasab commented Oct 17, 2023 •
edited
Loading

@jainruchir @pranavrth Great! We just need to fix the errors reported by flake8, merge master here with LK v2.3.0 and rerun the pipeline

emasab
emasab reviewed Oct 17, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments about the sphinx documentation

src/confluent_kafka/src/confluent_kafka.c Outdated Show resolved Hide resolved
src/confluent_kafka/admin/__init__.py Show resolved Hide resolved
src/confluent_kafka/__init__.py Outdated Show resolved Hide resolved
jainruchir and others added 19 commits October 20, 2023 13:16
emasab
emasab approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pranavrth pranavrth merged commit d69e310 into master Oct 23, 2023
1 check passed
@pranavrth pranavrth deleted the dev_kip430_rebase branch October 23, 2023 09:29
@pranavrth pranavrth mentioned this pull request Mar 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emasab emasab emasab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavrth @emasab @jainruchir