Address comment and RD_IF_FREE fixes

confluentinc · Sep 4, 2023 · 6239372 · 6239372
1 parent bdd8a4b
commit 6239372
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/rdkafka.c b/src/rdkafka.c
@@ -4797,7 +4797,7 @@ static void rd_kafka_ListGroups_resp_cb(rd_kafka_t *rk,
                 state->wait_cnt++;
                 error = rd_kafka_DescribeGroupsRequest(
                     rkb, 0, grps, i,
-                    rd_false /* include_authorized_operations */,
+                    rd_false /* don't include authorized operations */,
                     RD_KAFKA_REPLYQ(state->q, 0),
                     rd_kafka_DescribeGroups_resp_cb, state);
                 if (error) {

diff --git a/src/rdkafka_admin.c b/src/rdkafka_admin.c
@@ -8238,8 +8238,7 @@ rd_kafka_DescribeTopicsResponse_parse(rd_kafka_op_t *rko_req,
         return RD_KAFKA_RESP_ERR_NO_ERROR;
 
 err:
-        if (rko_result)
-                rd_kafka_op_destroy(rko_result);
+        RD_IF_FREE(rko_result, rd_kafka_op_destroy);
         rd_snprintf(errstr, errstr_size,
                     "DescribeTopics response protocol parse failure: %s",
                     rd_kafka_err2str(reply->rkbuf_err));
@@ -8491,8 +8490,7 @@ rd_kafka_DescribeClusterResponse_parse(rd_kafka_op_t *rko_req,
         return RD_KAFKA_RESP_ERR_NO_ERROR;
 
 err:
-        if (rko_result)
-                rd_kafka_op_destroy(rko_result);
+        RD_IF_FREE(rko_result, rd_kafka_op_destroy);
         rd_snprintf(errstr, errstr_size,
                     "DescribeCluster response protocol parse failure: %s",
                     rd_kafka_err2str(reply->rkbuf_err));