Modified example to use zookeeper to build the broker-list #104
Conversation
|
I'ts unclear to me how to make sure the ci process adds libzookeeper-mt-dev and libjansson-dev to the local build. Without it, you have missing headers and libs to build the example. |
|
Guess this needs to be added to the .travis.yml before_install: |
|
This change has some additional logging, added build dependencies to the rpm spec and travis ci check. The code is hopefully ready for another inspection ;-) |
| @@ -1,4 +1,4 @@ | |||
| EXAMPLES ?= rdkafka_example rdkafka_performance rdkafka_example_cpp | |||
| EXAMPLES ?= rdkafka_example rdkafka_performance rdkafka_example_cpp rdkafka_zookeeper_example | |||
There was a problem hiding this comment.
Remove rdkafka_zookeeper_example from this list, it will need to be built independently ('make rdkafka_zookeeper_example').
This is to avoid dependency on 3rd party libraries at this point.
|
Good stuff, but I dont want 3rd party library dependency requirements by default. This tool can still be built explicitly. |
Add build dependencies for libzookeper and libjansson Change to regular include structure Reformat code and add additional logging on brokers found
Added example to use zookeeper to build the broker-list
This is a modified version of the examples provided to load the initial set of brokers from zookeeper and to use the watch to modify the broker list when new brokers register or de-register.