Fix #1397 #1505
Merged
Fix #1397 #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With a zero rkb_blocking_max_ms the ua_idle() function would not serve broker queues and IOs resulting in the broker thread practically hanging and busy-looping. This fix makes sure we serve it at least once per spin. The previous fix makes sure rkb_blocking_max_ms is not 0.
9 tasks
mhowlett
reviewed
Nov 6, 2017
| * But honour the lower on-termination blocking time. */ | ||
| if (rd_kafka_terminating(rkb->rkb_rk)) | ||
| rkb->rkb_blocking_max_ms = 1; | ||
| else |
There was a problem hiding this comment.
my understanding is limited, but this looks good to me (resetting back to what it would be on a new connection). I wonder if you need to explicitly set this to 1 in the termination case though, but doesn't hurt.
There was a problem hiding this comment.
Worst case the thread will block on io-wait for blocking_max_ms (def 1000ms), this slows down termination, so we minimize the blocking time when we know that we are terminating.
|
looks good to the extent of my knowledge. I don't completely understand the reasoning behind the change in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is two fixes for the same thing, but they are valuable each on their own.