Destroy control messages in batch mode #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edenhill
reviewed
Jul 17, 2020
src/rdkafka_queue.c
Outdated
| @@ -603,7 +603,10 @@ int rd_kafka_q_serve_rkmessages (rd_kafka_q_t *rkq, int timeout_ms, | |||
| /* If this is a control messages, don't return | |||
| * message to application, only store the offset */ | |||
| if (unlikely(rd_kafka_op_is_ctrl_msg(rko))) | |||
There was a problem hiding this comment.
Please put open-brace on same line as if, like so:
if (unlikely(rd_kafka_op_is_ctrl_msg(rko))) {
..
edenhill
suggested changes
Jul 17, 2020
If there are control messages in the topic, rd_kafka_destroy will hang if only rd_kafka_consume_batch is used, rd_kafka_consume and rd_kafka_consume_callback don't have this issue. Release these messages before returning to the application.
pf-qiu
force-pushed
the
destroy_control_message
branch
from
a838e31 to
1a797f4
Compare
edenhill
approved these changes
Jul 20, 2020
|
Thanks for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there are control messages in the topic, rd_kafka_destroy will
hang if only rd_kafka_consume_batch is used, rd_kafka_consume and
rd_kafka_consume_callback don't have this issue.
Release these messages before returning to the application.