Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store offset commit metadata when calling rd_kafka_offsets_store #4171

Merged
merged 17 commits into from
May 16, 2023

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Feb 2, 2023

See forked PR #4084

Copy link
Contributor

@milindl milindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carrying over approval, based on the older PR.
Might require some clang-format stuff it seems from the Semaphore run.

Copy link
Contributor Author

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mathispesch ! Haven't reviewed it yet, but let's wait a bit for merging this as we want to make the complete suite of regression tests to pass on master.

@mathispesch
Copy link

Hey @emasab,
Wondering if you had a chance to review this 🙂. Not so sure what's the status with the test suite as I can't see the check details.

@mathispesch
Copy link

Hey @emasab,
Could you give this a look? This branch now has several conflicts with master. I can help to resolve them.

@mathispesch
Copy link

I've merged master into https://github.com/mathispesch/librdkafka/tree/store-offsets-metadata. Regression tests pass locally.

@mathispesch
Copy link

mathispesch commented Apr 4, 2023

Hey @emasab and @milindl,
Have you had a chance to look more into this? You should be able to rebase this on https://github.com/mathispesch/librdkafka/tree/store-offsets-metadata to resolve the conflicts with the base branch.

@emasab
Copy link
Contributor Author

emasab commented Apr 5, 2023

@mathispesch Sorry, this won't make it in this release because we want a release that contains KIP-320 asap. But will review it for next one.

@mathispesch
Copy link

Hey @emasab,
Is now a better time to give this one a look?

@emasab emasab merged commit 68455af into master May 16, 2023
@emasab emasab deleted the feature/store-offsets-metadata branch May 16, 2023 14:38
@mathispesch
Copy link

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants