-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store offset commit metadata when calling rd_kafka_offsets_store
#4171
Conversation
There's no CHANGELOG yet for the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Carrying over approval, based on the older PR.
Might require some clang-format stuff it seems from the Semaphore run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mathispesch ! Haven't reviewed it yet, but let's wait a bit for merging this as we want to make the complete suite of regression tests to pass on master.
Hey @emasab, |
Hey @emasab, |
I've merged master into https://github.com/mathispesch/librdkafka/tree/store-offsets-metadata. Regression tests pass locally. |
Hey @emasab and @milindl, |
@mathispesch Sorry, this won't make it in this release because we want a release that contains KIP-320 asap. But will review it for next one. |
Hey @emasab, |
rd_kafka_topic_partition_set_metadata_from_rktp_stored
Thanks a lot! |
See forked PR #4084