Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMake pkg-config issue with cURL require #4180

Merged
merged 7 commits into from
Apr 20, 2023
Merged

Conversation

emasab
Copy link
Contributor

@emasab emasab commented Feb 6, 2023

No description provided.

@emasab emasab requested review from milindl and pranavrth March 10, 2023 10:50
@dvzrv
Copy link

dvzrv commented Apr 8, 2023

Please also consider #4165 and #4193 since they fix related issues

emasab and others added 4 commits April 11, 2023 17:44
The name of Curl library is libcurl instead of curl. WITH_SSL also needs
libcrypto. Requires.private is more appropriate the Requires. Those
changes are referenced from pc file generated by Make.
Copy link
Contributor

@milindl milindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on discussion yesterday

@emasab emasab merged commit 295ba3c into master Apr 20, 2023
@emasab emasab deleted the feature/fix-cmake-curl branch April 20, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants