Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hang in incremental assign during close #4528

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Fix hang in incremental assign during close #4528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ librdkafka v2.4.0 is a feature release:
a consumer group (#4678).
* Fix to metadata refresh interruption (#4679).
* Fix for an undesired partition migration with stale leader epoch (#4680).
* Fix hang in cooperative consumer mode if an assignment is processed
while closing the consumer (#4528).


## Upgrade considerations
Expand Down Expand Up @@ -79,6 +81,12 @@ librdkafka v2.4.0 is a feature release:
Fixed by ensuring that a resume operation is completely a no-op when
the partition isn't paused.
Happening since 1.x (#4636).
* Issues: #4527.
While using the cooperative assignor, given an assignment is received while closing the consumer
it's possible that it gets stuck in state WAIT_ASSIGN_CALL, while the method is converted to
a full unassign. Solved by changing state from WAIT_ASSIGN_CALL to WAIT_UNASSIGN_CALL
while doing this conversion.
Happening since 1.x (#4528).



Expand Down
2 changes: 1 addition & 1 deletion tests/test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7307,7 +7307,7 @@ const char *test_consumer_group_protocol() {

int test_consumer_group_protocol_generic() {
return !test_consumer_group_protocol_str ||
!strcmp(test_consumer_group_protocol_str, "generic");
!strcmp(test_consumer_group_protocol_str, "classic");
}

int test_consumer_group_protocol_consumer() {
Expand Down
2 changes: 1 addition & 1 deletion tests/test.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ static RD_INLINE RD_UNUSED void rtrim(char *str) {
return RET; \
} \
if (test_consumer_group_protocol() && \
strcmp(test_consumer_group_protocol(), "generic")) { \
strcmp(test_consumer_group_protocol(), "classic")) { \
TEST_SKIP( \
"Mock cluster cannot be used " \
"with group.protocol=%s\n", \
Expand Down