Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding int identifier for transactional ID #4803

Conversation

JohnPreston
Copy link
Contributor

Adding the int ID for transactional ID, to enable using that as a ResourceType in the clients (python being my use-case specifically)

@JohnPreston JohnPreston requested a review from a team as a code owner August 5, 2024 11:10
Copy link

cla-assistant bot commented Aug 5, 2024

CLA assistant check
All committers have signed the CLA.

@pranavrth
Copy link
Member

/sem-approve

Copy link
Member

@pranavrth pranavrth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style check and tests are failing. Please fix those.

To fix style check, run make style-check-changed for the changed code. Note that the change code is uncommitted code.

src/rdkafka.h Outdated Show resolved Hide resolved
@JohnPreston
Copy link
Contributor Author

JohnPreston commented Aug 12, 2024

/sem-approve
Well that was worth a shot :D
@pranavrth can you please re-trigger the tests?

@JohnPreston JohnPreston requested a review from pranavrth August 13, 2024 15:28
@pranavrth
Copy link
Member

/sem-approve

@JohnPreston
Copy link
Contributor Author

I mean, the style check I ran the command to fix that locally so I don't know what else to do here :/
I am not sure why the tests pass on some architecture but not with others. Given that the validation test is to check the value as per a statically expected set of returns, I am not sure how that comes to be.

Any suggestions?

@pranavrth
Copy link
Member

pranavrth commented Aug 22, 2024

The style check works with uncommitted and unstaged changes. Can you try to uncommit your changes and then run make style-fix-changed and then force push the changes to this branch after committing.

Test still fails. Failing on different architecture is not related to the test cases. Its something else that I can check later when the style check and tests passes. Please focus on the Linux Ubuntu x64: source build and Style check jobs in the CI.

Screenshot 2024-08-22 130127

@pranavrth
Copy link
Member

Closing this PR.
Continued in #4856

@pranavrth pranavrth closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants