Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding int identifier for transactional ID #4856

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

pranavrth
Copy link
Member

Continuation of #4803

@pranavrth pranavrth requested a review from a team as a code owner September 30, 2024 19:48
@confluent-cla-assistant
Copy link

confluent-cla-assistant bot commented Sep 30, 2024

🎉 All Contributor License Agreements have been signed. Ready to merge.
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@pranavrth
Copy link
Member Author

@JohnPreston - I have fixed the style check and tests. Can you please sign the CLA?

@JohnPreston
Copy link
Contributor

Done @pranavrth

Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Pranav please just add the CHANGELOG entry and run a style fix on 0080-admin_ut and it's good to merge.

@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_add-transactional-id-acl-resource branch from db80598 to d31bced Compare October 4, 2024 08:54
@airlock-confluentinc airlock-confluentinc bot force-pushed the dev_add-transactional-id-acl-resource branch from d31bced to d649e37 Compare October 9, 2024 11:30
@pranavrth pranavrth enabled auto-merge (squash) October 9, 2024 12:01
@pranavrth pranavrth merged commit 54480ef into master Oct 9, 2024
3 checks passed
@pranavrth pranavrth deleted the dev_add-transactional-id-acl-resource branch October 9, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants