From 26147b448d2d434f99dfbe90074bb2d5572fd437 Mon Sep 17 00:00:00 2001
From: Grant Birchmeier <gbirchmeier@connamara.com>
Date: Mon, 9 Sep 2024 10:27:45 -0500
Subject: [PATCH] fix #878: corrections to DD enums for Side

---
 QuickFIXn/Fields/Fields.cs | 2 --
 RELEASE_NOTES.md           | 7 +++++++
 spec/fix/FIX41.xml         | 2 +-
 spec/fix/FIX42.xml         | 2 +-
 spec/fix/FIX50.xml         | 2 +-
 spec/fix/FIX50SP1.xml      | 2 +-
 6 files changed, 11 insertions(+), 6 deletions(-)

diff --git a/QuickFIXn/Fields/Fields.cs b/QuickFIXn/Fields/Fields.cs
index be9386a2b..ea5869cdf 100644
--- a/QuickFIXn/Fields/Fields.cs
+++ b/QuickFIXn/Fields/Fields.cs
@@ -1286,8 +1286,6 @@ public Side(char val)
         public const char REDEEM = 'E';
         public const char LEND = 'F';
         public const char BORROW = 'G';
-        public const char CROSS_SHORT_EXXMPT = 'A';
-        public const char D = '7';
     }
 
 
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
index 33f901f00..43dc9201e 100644
--- a/RELEASE_NOTES.md
+++ b/RELEASE_NOTES.md
@@ -13,6 +13,13 @@ What's New
 * **There are breaking changes between 1.10 and 1.11!  Please review the 1.11.0 notes below.**
 
 
+### (next release)
+
+**Breaking changes**
+* #878 - corrections to tag 45 "Side" in various DDs (gbirchmeier)
+     * fix typo in FIX50 and FIX50SP1: `CROSS_SHORT_EXXMPT` fixed to `CROSS_SHORT_EXEMPT`
+     * correction in FIX41 and FIX42: `D` to `UNDISCLOSED`
+
 ### v1.12.0
 
 **Breaking changes**
diff --git a/spec/fix/FIX41.xml b/spec/fix/FIX41.xml
index 430fdfe9f..7f699b46f 100644
--- a/spec/fix/FIX41.xml
+++ b/spec/fix/FIX41.xml
@@ -863,7 +863,7 @@
       <value enum="4" description="SELL_PLUS"/>
       <value enum="5" description="SELL_SHORT"/>
       <value enum="6" description="SELL_SHORT_EXEMPT"/>
-      <value enum="7" description="D"/>
+      <value enum="7" description="UNDISCLOSED"/>
       <value enum="8" description="CROSS"/>
     </field>
     <field number="55" name="Symbol" type="STRING"/>
diff --git a/spec/fix/FIX42.xml b/spec/fix/FIX42.xml
index 575fc6230..8b0e4ebbd 100644
--- a/spec/fix/FIX42.xml
+++ b/spec/fix/FIX42.xml
@@ -1796,7 +1796,7 @@
       <value enum="4" description="SELL_PLUS"/>
       <value enum="5" description="SELL_SHORT"/>
       <value enum="6" description="SELL_SHORT_EXEMPT"/>
-      <value enum="7" description="D"/>
+      <value enum="7" description="UNDISCLOSED"/>
       <value enum="8" description="CROSS"/>
       <value enum="9" description="CROSS_SHORT"/>
     </field>
diff --git a/spec/fix/FIX50.xml b/spec/fix/FIX50.xml
index f8ac7b5b0..9264e0ae7 100644
--- a/spec/fix/FIX50.xml
+++ b/spec/fix/FIX50.xml
@@ -4776,7 +4776,7 @@
    <value enum='7' description='UNDISCLOSED' />
    <value enum='8' description='CROSS' />
    <value enum='9' description='CROSS_SHORT' />
-   <value enum='A' description='CROSS_SHORT_EXXMPT' />
+   <value enum='A' description='CROSS_SHORT_EXEMPT' />
    <value enum='B' description='AS_DEFINED' />
    <value enum='C' description='OPPOSITE' />
    <value enum='D' description='SUBSCRIBE' />
diff --git a/spec/fix/FIX50SP1.xml b/spec/fix/FIX50SP1.xml
index 3214c713b..086748db2 100644
--- a/spec/fix/FIX50SP1.xml
+++ b/spec/fix/FIX50SP1.xml
@@ -5523,7 +5523,7 @@
    <value enum='7' description='UNDISCLOSED' />
    <value enum='8' description='CROSS' />
    <value enum='9' description='CROSS_SHORT' />
-   <value enum='A' description='CROSS_SHORT_EXXMPT' />
+   <value enum='A' description='CROSS_SHORT_EXEMPT' />
    <value enum='B' description='AS_DEFINED' />
    <value enum='C' description='OPPOSITE' />
    <value enum='D' description='SUBSCRIBE' />