lib: fix memory corruption #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current commit fixes an invalid memory access which manifests as a random segfault when executing continuous tag read operations. The corruption happens when releasing the memory allocated to a record: in the time between the memory being g_free'd and the subsequent memset operation, the memory could have been reused by some other process. And since memory allocation depends on system-wide factors, it makes this bug hard to track. Tested using ACR122U reader and NTAG213 tags on Automotive Grade Linux (flounder, guppy and master branches) Signed-off-by: Raquel Medina <raquel.medina@konsulko.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current commit fixes an invalid memory access
which manifests as a random segfault when executing
continuous tag read operations.
The corruption happens when releasing the memory allocated to a
record: in the time between the memory being g_free'd and the
subsequent memset operation, the memory could have been reused by
some other process. And since memory allocation depends on
system-wide factors, it makes this bug hard to track.
Tested using ACR122U reader and NTAG213
tags on Automotive Grade Linux (flounder,
guppy and master branches)
Signed-off-by: Raquel Medina raquel.medina@konsulko.com