From 5135d9c1def750422e4a8f7718ba1926242695dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ant=C3=B3nio=20Regadas?= Date: Tue, 2 Jul 2024 14:45:24 +0100 Subject: [PATCH] fix(version bump): manual version bump and clean up (#762) --- .release-please-manifest.json | 2 +- packages/custodyController/package.json | 2 +- packages/custodyKeyring/src/CustodyKeyring.ts | 2 -- packages/sdk/src/classes/MMISDK.ts | 4 ---- packages/sdk/src/custodianApi/json-rpc/JsonRpcCustodianApi.ts | 2 -- 5 files changed, 2 insertions(+), 10 deletions(-) diff --git a/.release-please-manifest.json b/.release-please-manifest.json index deba88f7..254b4b24 100644 --- a/.release-please-manifest.json +++ b/.release-please-manifest.json @@ -2,7 +2,7 @@ "packages/institutionalFeatures": "1.3.5", "packages/simpleCache": "1.1.0", "packages/types": "1.1.0", - "packages/custodyController": "0.2.30", + "packages/custodyController": "0.2.31", "packages/custodyKeyring": "2.0.3", "packages/sdk": "0.1.30", "packages/transactionUpdate": "0.2.5", diff --git a/packages/custodyController/package.json b/packages/custodyController/package.json index 3f7deccd..a9dd011e 100644 --- a/packages/custodyController/package.json +++ b/packages/custodyController/package.json @@ -1,6 +1,6 @@ { "name": "@metamask-institutional/custody-controller", - "version": "0.2.30", + "version": "0.2.31", "description": "Custody controller is a background controller responsible for maintaining a cache of custody data in local storage", "author": "Albert Olive ", "homepage": "https://github.com/consensys-vertical-apps/metamask-institutional#readme", diff --git a/packages/custodyKeyring/src/CustodyKeyring.ts b/packages/custodyKeyring/src/CustodyKeyring.ts index f0e2f3b0..88ebf5e7 100644 --- a/packages/custodyKeyring/src/CustodyKeyring.ts +++ b/packages/custodyKeyring/src/CustodyKeyring.ts @@ -455,8 +455,6 @@ export abstract class CustodyKeyring extends EventEmitter { return this.accountsDetails.find(account => account.address.toLowerCase() === address.toLowerCase()); } - // TODO: This methods should be rename 'get signed message' - async getSignature(address: string, signatureId: string): Promise { if (signatureId === undefined) { return null; diff --git a/packages/sdk/src/classes/MMISDK.ts b/packages/sdk/src/classes/MMISDK.ts index a9b029e1..4e108060 100644 --- a/packages/sdk/src/classes/MMISDK.ts +++ b/packages/sdk/src/classes/MMISDK.ts @@ -186,7 +186,3 @@ export class MMISDK extends EventEmitter { } export { ICustodianDetails } from "../interfaces/ICustodianDetails"; - -// @TODO We don't need it right now, come back later after CustodyKeyring is in its own package -// and check if we still want to export it here for some reason -// export { CustodyKeyring } from "./CustodyKeyring"; diff --git a/packages/sdk/src/custodianApi/json-rpc/JsonRpcCustodianApi.ts b/packages/sdk/src/custodianApi/json-rpc/JsonRpcCustodianApi.ts index fb3147aa..6d125703 100644 --- a/packages/sdk/src/custodianApi/json-rpc/JsonRpcCustodianApi.ts +++ b/packages/sdk/src/custodianApi/json-rpc/JsonRpcCustodianApi.ts @@ -71,8 +71,6 @@ export class JsonRpcCustodianApi extends EventEmitter implements ICustodianApi { async getEthereumAccountsByAddress(address: string): Promise[]> { const accounts = await this.getEthereumAccounts(); - // TODO: This is a bit inefficient, but eventually we may add optional filtering to the JSON-RPC API - return accounts.filter(account => account.address.toLowerCase().includes(address.toLowerCase())); }