Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace arm64 minor variant logic with lookup table #17

Closed
samuelkarp opened this issue Nov 4, 2024 · 0 comments · Fixed by #18
Closed

Replace arm64 minor variant logic with lookup table #17

samuelkarp opened this issue Nov 4, 2024 · 0 comments · Fixed by #18

Comments

@samuelkarp
Copy link
Member

Follow up from #8:

LGTM; although if this gets any more complicated it might be easier to have some form of lookup table rather than trying to follow a set of for loops?

(@estesp)

LGTM per discussion in the maintainer channel, though +1 to @estesp's comment; this is probably much easier to maintain if we convert it to a lookup table rather than math and loops.

(@samuelkarp)

@dmcgowan also pointed to https://en.wikipedia.org/wiki/AArch64 and https://community.arm.com/arm-community-blogs/b/architectures-and-processors-blog/posts/arm-a-profile-architecture-developments-2024 to document some of the complexity in arm64 variant logic. The matching pairs of 8.5|9.0 until 9.5, and some instructions added to 9.x only make it difficult for us to accurately capture the compatibility in logic and ensure that it is kept up to date as Arm development continues. While a lookup table would be more tedious to write initially, it would be clear to understand at a glance which minor variants are compatible with each other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant