Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: Use sfdisk, not lsblk #688

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

cgwalters
Copy link
Collaborator

This works around an issue where lsblk ends up parsing data cached from udev in /run/udev, but we don't have that mounted by default.

Adding a new mount point hard requirement is logistically complicated right now - we will eventually switch
to dynamic mounts with open_tree (cc
#380 )
but this is a relatively straightforward workaround.

@github-actions github-actions bot added the area/install Issues related to `bootc install` label Jul 16, 2024
This works around an issue where `lsblk` ends up parsing
data cached from udev in `/run/udev`, but we don't have that
mounted by default.

Adding a new mount point hard requirement is logistically
complicated right now - we will eventually switch
to dynamic mounts with `open_tree` (cc
containers#380 )
but this is a relatively straightforward workaround.

Signed-off-by: Colin Walters <walters@verbum.org>
@cgwalters
Copy link
Collaborator Author

 > bootupctl backend install --write-uuid --device /dev/loop0 /run/bootc/mounts/rootfs
cp: error writing '/run/bootc/mounts/rootfs/boot/efi/EFI/centos/shimx64-centos.efi': No space left on device
cp: error writing '/run/bootc/mounts/rootfs/boot/efi/EFI/centos/shimx64.efi': No space left on device
cp: error writing '/run/bootc/mounts/rootfs/boot/efi/EFI/centos/mmx64.efi': No space left on device
cp: error writing '/run/bootc/mounts/rootfs/boot/efi/EFI/centos/grubx64.efi': No space left on device
cp: error writing '/run/bootc/mounts/rootfs/boot/efi/EFI/BOOT/BOOTX64.EFI': No space left on device
cp: error writing '/run/bootc/mounts/rootfs/boot/efi/EFI/BOOT/fbx64.efi': No space left on device
error: boot data installation failed: installing component EFI: Failed to copy
ERROR Installing to disk: Installing bootloader: Task Running bootupctl to install bootloader failed: ExitStatus(unix_wait_status(256))

Hmm that's a new one. It's a bit baffling, looking at the space on the host before:

+ df -h /
Filesystem      Size  Used Avail Use% Mounted on
/dev/root        72G   34G   38G  48% /

And the rootfs size is fine:

 Creating root filesystem (xfs) on device /dev/loop0p3 (size=9.5 GB)

And the container image size is fine:

 layers already present: 0; layers needed: 74 (1.7 GB)

Copy link
Contributor

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgwalters cgwalters merged commit 21447f2 into containers:main Jul 16, 2024
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/install Issues related to `bootc install`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants