Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy: Add a spinner #848

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Commits on Oct 27, 2024

  1. deploy: Use bar.println

    In some cases I wasn't seeing this output, and I think it's
    because we hadn't `drop()`'d the bar. Since it's in scope
    it's cleaner to use its `println` method.
    
    Signed-off-by: Colin Walters <walters@verbum.org>
    cgwalters committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    7f64565 View commit details
    Browse the repository at this point in the history
  2. deploy: Add a spinner

    First, this operation was absolutely not asynchronous
    and we need to spawn it in a helper thread on general
    principle. Doing that is unfortunately VERY hacky
    because we need to clone a lot of things and especially
    there's an ergonomics hit here since `Deployment` is
    incorrectly `!Send`.
    
    But the main motivation is this operation can be slow sometimes,
    so let's show progress output so the admin knows we're not blocked.
    
    Closes: containers#842
    Signed-off-by: Colin Walters <walters@verbum.org>
    cgwalters committed Oct 27, 2024
    Configuration menu
    Copy the full SHA
    3638b41 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. utils: Print and log time for async_task_with_spinner

    Things we do via this mechanism can take some time; let's
    log the elapsed time for greater visibility both to the
    human output *and* log to the journal.
    
    Signed-off-by: Colin Walters <walters@verbum.org>
    cgwalters committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    daeafea View commit details
    Browse the repository at this point in the history