Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conmon-rs always opens a namespace, even if it won't be used #1081

Open
haircommander opened this issue Feb 2, 2023 · 4 comments
Open

conmon-rs always opens a namespace, even if it won't be used #1081

haircommander opened this issue Feb 2, 2023 · 4 comments
Assignees

Comments

@haircommander
Copy link
Collaborator

haircommander commented Feb 2, 2023

after #1064, conmon-rs always opens a namespace, even if the pod needs a container level namespace. This isn't a behavior problem, but does needlessly add extra mounts and will cause there to be more open files then needed.

@saschagrunert
Copy link
Member

saschagrunert commented Feb 3, 2023

@haircommander would it make sense to extend the CLI/Cap'n Proto interface in the same way we have in pinns, for example:

conmonrs pause --ipc       # Unshare to a new IPC namespace
conmonrs pause --ipc=host  # Unshare to the host IPC namespace
conmonrs pause             # Skip unsharing the IPC namespace

@haircommander
Copy link
Collaborator Author

yeah I think so

@haircommander
Copy link
Collaborator Author

also having a target for posterity would be useful (where we just bind mount a path of a namespace)

@haircommander haircommander self-assigned this Feb 3, 2023
@haircommander
Copy link
Collaborator Author

I started working on this but didn't finish. I will try to finish next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants