From 30e60e0be6ed69acf591cb978bd3faabb4a6ca20 Mon Sep 17 00:00:00 2001 From: Ivan Shapovalov Date: Mon, 8 Sep 2025 00:01:46 +0200 Subject: [PATCH] storage: overlay: only unmount storage home if needed Do not attempt to unmount storage home directory if we were not supposed to mount or remount it at all. This is never useful and may also break certain (unsupported) setups. Fixes: containers/podman#27012 Signed-off-by: Ivan Shapovalov --- storage/drivers/overlay/overlay.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/storage/drivers/overlay/overlay.go b/storage/drivers/overlay/overlay.go index f65b2c515a..faae4992e7 100644 --- a/storage/drivers/overlay/overlay.go +++ b/storage/drivers/overlay/overlay.go @@ -863,7 +863,11 @@ func (d *Driver) Cleanup() error { if anyPresent { return nil } - return mount.Unmount(d.home) + // Ensure that we do not unmount anything not mounted by us + if !d.options.skipMountHome { + return mount.Unmount(d.home) + } + return nil } // pruneStagingDirectories cleans up any staging directory that was leaked.