From 4f387117f9182246763ca48d51628440f9ed67c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miloslav=20Trma=C4=8D?= Date: Sat, 8 Jan 2022 17:46:21 +0100 Subject: [PATCH] Add a note about (unsquashfs -o) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Miloslav Trmač --- sif/load.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sif/load.go b/sif/load.go index 4f48b9be2e..d17d7dbb7b 100644 --- a/sif/load.go +++ b/sif/load.go @@ -180,6 +180,9 @@ func convertSIFToElements(ctx context.Context, sifImage *sif.FileImage, tempDir if err != nil { return "", nil, fmt.Errorf("looking up rootfs from SIF file: %w", err) } + // TODO: We'd prefer not to make a full copy of the file here; unsquashfs ≥ 4.4 + // has an -o option that allows extracting a squashfs from the SIF file directly, + // but that version is not currently available in RHEL 8. if err := func() error { // A scope for defer f, err := os.Create(squashFSPath) if err != nil {