Add SMBIOS OEM Strings support #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germag
force-pushed
the
add-smbios-oem-strings
branch
3 times, most recently
from
ea02118
to
8053890
Compare
|
containers/libkrun#187 has been merged, so this is ready for review |
|
neither clippy nor rustfmt fail locally, idk why the CI/CD work is failing |
I've tried restarting the job and it never gets picked by a running. I'm not sure what's happening here, could you please force-push to see if the action gets triggered again? |
Signed-off-by: German Maglione <gmaglione@redhat.com>
germag
force-pushed
the
add-smbios-oem-strings
branch
from
8053890
to
b89997c
Compare
|
Since the CI/CD refuses to run in this PR, I'm creating a new one. So, I'm closing this PR in favor of #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new commandline option
--oem-string <STRING>to support SMBIOS OEM strings via calling the new libkrun's APIkrun_set_smbios_oem_strings()[0].Note: this is marked as draft until [0] is merged
[0] containers/libkrun#187