Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using podman-mac-helper install, does not exit 1 on error #17785

Closed
cdrage opened this issue Mar 14, 2023 · 1 comment · Fixed by #17786
Closed

When using podman-mac-helper install, does not exit 1 on error #17785

cdrage opened this issue Mar 14, 2023 · 1 comment · Fixed by #17786
Assignees
@Luap99
Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@cdrage
Copy link

cdrage commented Mar 14, 2023

Issue Description

When running podman-mac-helper install despite there being an install already, the tool does not exit with error 1, but instead error 0.

dev/electron/podman-desktop  add-button-compatibility-mode-macos ✗                                                                                                                                                                                                                                           2m ⚑  ⍉
▶ sudo podman-mac-helper install
Password:
Error: helper is already installed, uninstall first

dev/electron/podman-desktop  add-button-compatibility-mode-macos ✗                                                                                                                                                                                                                                            2m ⚑  
▶ echo $?
0

Steps to reproduce the issue

Steps to reproduce the issue

  1. podman-mac-helper install
  2. Run it again
  3. echo $? shows 0 when it should be 1

Describe the results you received

Error 0.

Describe the results you expected

Should be error 1 not 0.

podman info output

N/A, I'm using `podman-mac-helper`.

Podman in a container

No

Privileged Or Rootless

None

Upstream Latest Release

Yes

Additional environment details

Additional environment details

Additional information

Additional information like issue happens only occasionally or issue happens with a particular architecture or on a particular setting
@cdrage cdrage added the kind/bug Categorizes issue or PR as related to a bug. label Mar 14, 2023
@Luap99 Luap99 self-assigned this Mar 14, 2023
@Luap99 Luap99 added the In Progress This issue is actively being worked by the assignee, please do not work on this at this time. label Mar 14, 2023
Luap99 added a commit to Luap99/libpod that referenced this issue Mar 14, 2023
@Luap99
podman-mac-helper: exit 1 on error
367cb98 
We should return a proper exit code to signal the failure.

Fixes containers#17785

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99 Luap99 mentioned this issue Mar 14, 2023
Merged
@Luap99
Copy link
Member

Luap99 commented Mar 14, 2023

Fix in #17786

Luap99 added a commit to Luap99/libpod that referenced this issue Mar 14, 2023
@Luap99
podman-mac-helper: exit 1 on error
bae07b6 
We should return a proper exit code to signal the failure.

[NO NEW TESTS NEEDED] We do have any tests on macOS.

Fixes containers#17785

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99 added a commit to Luap99/libpod that referenced this issue Mar 16, 2023
@Luap99
podman-mac-helper: exit 1 on error
8ab0042 
We should return a proper exit code to signal the failure.

[NO NEW TESTS NEEDED] We do have any tests on macOS.

Fixes containers#17785

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Luap99 Luap99

Labels
In Progress This issue is actively being worked by the assignee, please do not work on this at this time. kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

podman-mac-helper: exit 1 on error Luap99/libpod
2 participants
@cdrage @Luap99