-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test/system: Ensure that the user is part of a group with the same name, and the process started by 'podman exec' has all groups #1447
Conversation
369ab68
to
0669a85
Compare
Build succeeded. ✔️ unit-test SUCCESS in 4m 41s |
Build failed. ✔️ unit-test SUCCESS in 4m 43s |
Commit 15173f8 exposed a bug in crun(1) [1] where the process started directly by 'podman exec --user ...' inside the Toolbx container would not have the supplementary groups attached to the user by the entry point. This could be observed by differences in id(1): ⬢$ id uid=1000(user) gid=1000(user) groups=1000(user) ⬢$ id user uid=1000(user) gid=1000(user) groups=1000(user),10(wheel) ... and could be worked around by starting a new session with sudo(8). [1] crun commit 9effaebb429a1aed containers/crun@9effaebb429a1aed containers/crun#644 containers/podman#9986 containers#608
127b6b7
to
641b04a
Compare
Build succeeded. ✔️ unit-test SUCCESS in 5m 11s |
assert_line --regexp "^sudo:x:[[:digit:]]+:$USER$" | ||
assert [ ${#lines[@]} -gt 1 ] | ||
|
||
# shellcheck disable=SC2154 | ||
assert [ ${#stderr_lines[@]} -eq 0 ] | ||
} | ||
|
||
@test "user: id(1) for $USER inside the default container" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests fail if I revert the crun fix. So, I suppose they serve their purpose.
#608