Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for omniauth v2.0.0 #9

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Conversation

BobbyMcWho
Copy link
Contributor

@BobbyMcWho BobbyMcWho commented Dec 11, 2020

OmniAuth v2.0.0 has been released, this change allows folks to use v2.0.0 without manually setting a request_validation_phase that is required for rails apps using OmniAuth v2.0.0

2.0.0 release notes

@nsommer
Copy link

nsommer commented Jan 12, 2021

Since omniauth 2 is now released, can we merge & release this change, too? :)

@BobbyMcWho BobbyMcWho marked this pull request as ready for review January 13, 2021 19:17
@BobbyMcWho BobbyMcWho changed the title [Draft] Support for in-development omniauth v2.0.0-rc1 Support for omniauth v2.0.0 Jan 13, 2021
Copy link
Collaborator

@sikachu sikachu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

I agree with you re: bumping this to 1.0.0 since switching to requst_validation_phrase is a breaking change.

I'll merge and release this shortly.

@sikachu sikachu merged commit b87ac3f into cookpad:master Jan 14, 2021
davidrunger added a commit to davidrunger/david_runger that referenced this pull request Jan 28, 2021
The mentioned PR
(cookpad/omniauth-rails_csrf_protection#9) has
been merged and released in `omniauth-rails_csrf_protection` 1.0.0
(which we are using).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants