Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of dash,hls #184

Closed
olypros opened this issue Apr 26, 2017 · 8 comments
Closed

Support of dash,hls #184

olypros opened this issue Apr 26, 2017 · 8 comments

Comments

@olypros
Copy link

olypros commented Apr 26, 2017

Does it supports dash and hls ? anytime soon ?

@cookpete
Copy link
Owner

The player falls back to <video> if the url passed in cannot be played by any of the custom players. Any browser that supports HLS or DASH will work. Try opening this fiddle in Safari to see ReactPlayer working with one of Apple's example HLS streams.

@oyeanuj
Copy link

oyeanuj commented May 9, 2017

Hey @cookpete, so it seems that your link above works only in Safari since that comes with native support for HLS. What do you think about adding HLS.js or Dash.js, so that they play in all the browsers?

FWIW as reference implementations, Clappr and Shaka-player seems to be supporting both HLS and DASH (more iffy).

Here is one player integrating it in React as a reference: https://github.com/foxford/react-hls/blob/master/src/HLSPlayer.jsx#L98

@oyeanuj
Copy link

oyeanuj commented May 9, 2017

@cookpete To provide more context for this request, I am thinking that if we incorporate these two libraries, then that might mean that it should (theoretically) work on all browsers, which would mean a huge saving in encoding cost, since you are only encoding to one format (and not needing to deal with multiple resolutions either).

Thoughts?

@cookpete
Copy link
Owner

cookpete commented May 9, 2017

@oyeanuj I wasn't aware of these libraries until now but they looks like a good solution. I have integration with hls.js working for .m3u8 URLs so will publish that soon after I look at supporting dash too. In the meantime, are there any other HLS file extensions to detect? I've also added a forceHLS config option to fileConfig for more ambiguous URLs.

@oyeanuj
Copy link

oyeanuj commented May 9, 2017

@cookpete Awesome, thats good to hear! For hls, it seems like .m3u8 would be sufficient according to Apple.

Will have to study MPEG-DASH more to respond for that.

@cookpete
Copy link
Owner

cookpete commented May 9, 2017

The dash.js readme examples use manifest.mpd so I'll use mpd for now, and add a forceDASH boolean to fileConfig.

cookpete added a commit that referenced this issue May 9, 2017
@cookpete
Copy link
Owner

cookpete commented May 9, 2017

Published in 0.18.0

@oyeanuj
Copy link

oyeanuj commented May 9, 2017

wow, that was quick!

david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue Dec 23, 2018
david-hub024 pushed a commit to david-hub024/React_VideoPlayer that referenced this issue May 23, 2020
albanqoku added a commit to albanqoku/react-player that referenced this issue Feb 24, 2021
Webmaster1116 added a commit to Webmaster1116/video-player that referenced this issue May 20, 2021
webmiraclepro added a commit to webmiraclepro/video-player that referenced this issue Sep 9, 2022
philip-luther added a commit to philip-luther/react-player that referenced this issue Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants