-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update HLS and DASH SDK to use latest versions #513
Conversation
There is already some logic in the I'm wary of always loading the absolute latest version of any SDK. Any future change that may cause an error will break every implementation of ReactPlayer everywhere. Maybe a better solution would be to hardcode the current latest (after testing it works), then add |
Also bump to latest versions Closes #513
de8d961 is actually addressing a different issue from the SDK loading multiple times. It actually handles the scenario where if you load an HLS file player for the first time, then unmount it before the SDK has async loaded, the SDK load promise resolves and it creates the hlsPlayer and starts loading the HLS src even the react-player is no longer mounted (and hence impossible to access and destroy this newly created hlsPlayer) |
Also bump to latest versions Closes cookpete/react-player#513
Also bump to latest versions Closes cookpete/react-player#513
Also bump to latest versions Closes cookpete/react-player#513
Also bump to latest versions Closes cookpete/react-player#513
Also bump to latest versions Closes cookpete/react-player#513
Also bump to latest versions Closes cookpete/react-player#513
Use HLS/DASH library url's taken from respective projects' readme's
Prevent loading of HLS/Dash media source if player has already unmounted