From 6d5fbbd186d50a681bc93cf25585c1db93f6dca2 Mon Sep 17 00:00:00 2001 From: Carmen Bianca BAKKER Date: Thu, 11 Jul 2024 14:20:59 +0200 Subject: [PATCH] fixup! [ADD] hr_timesheet_overtime_begin_end Signed-off-by: Carmen Bianca BAKKER --- hr_timesheet_overtime_rate/README.rst | 7 ------- hr_timesheet_overtime_rate/readme/ROADMAP.rst | 7 ------- hr_timesheet_overtime_rate/static/description/index.html | 6 ------ 3 files changed, 20 deletions(-) diff --git a/hr_timesheet_overtime_rate/README.rst b/hr_timesheet_overtime_rate/README.rst index f2fe4ca..ccb27d5 100644 --- a/hr_timesheet_overtime_rate/README.rst +++ b/hr_timesheet_overtime_rate/README.rst @@ -39,13 +39,6 @@ At time of writing (2024-06-28), the way a rate is computed for a date is by looking _exclusively_ at the corresponding day of the week. This should be more robust. -Because ``unit_amount`` is computed from ``hours_worked``, this module is not -compatible with ``hr_timesheet_begin_end``.To make this module subsequently -compatible with ``hr_timesheet_begin_end``, ``hours_worked`` must be computed -from ``time_stop`` and ``time_start``, and ``unit_amount`` must use this -module's computation method instead of ``hr_timesheet_begin_end``'s. The -compatibility layer should go into its own module. - Furthermore, the summary view of timesheet sheets are set read-only in this module. Because of programming complexities, it is not easy to change this view to use ``hours_worked`` instead of ``unit_amount``. diff --git a/hr_timesheet_overtime_rate/readme/ROADMAP.rst b/hr_timesheet_overtime_rate/readme/ROADMAP.rst index f6a36a7..d84795b 100644 --- a/hr_timesheet_overtime_rate/readme/ROADMAP.rst +++ b/hr_timesheet_overtime_rate/readme/ROADMAP.rst @@ -5,13 +5,6 @@ At time of writing (2024-06-28), the way a rate is computed for a date is by looking _exclusively_ at the corresponding day of the week. This should be more robust. -Because ``unit_amount`` is computed from ``hours_worked``, this module is not -compatible with ``hr_timesheet_begin_end``.To make this module subsequently -compatible with ``hr_timesheet_begin_end``, ``hours_worked`` must be computed -from ``time_stop`` and ``time_start``, and ``unit_amount`` must use this -module's computation method instead of ``hr_timesheet_begin_end``'s. The -compatibility layer should go into its own module. - Furthermore, the summary view of timesheet sheets are set read-only in this module. Because of programming complexities, it is not easy to change this view to use ``hours_worked`` instead of ``unit_amount``. diff --git a/hr_timesheet_overtime_rate/static/description/index.html b/hr_timesheet_overtime_rate/static/description/index.html index dd99b2d..eeb6ed2 100644 --- a/hr_timesheet_overtime_rate/static/description/index.html +++ b/hr_timesheet_overtime_rate/static/description/index.html @@ -391,12 +391,6 @@

Known issues / Roadmap

At time of writing (2024-06-28), the way a rate is computed for a date is by looking _exclusively_ at the corresponding day of the week. This should be more robust.

-

Because unit_amount is computed from hours_worked, this module is not -compatible with hr_timesheet_begin_end.To make this module subsequently -compatible with hr_timesheet_begin_end, hours_worked must be computed -from time_stop and time_start, and unit_amount must use this -module’s computation method instead of hr_timesheet_begin_end’s. The -compatibility layer should go into its own module.

Furthermore, the summary view of timesheet sheets are set read-only in this module. Because of programming complexities, it is not easy to change this view to use hours_worked instead of unit_amount.