[WIP] Adds types to Anchor #537
Conversation
|
cc @cheaney might be helping with this |
|
@armaniferrante I made the Also note that I needed to add a bash script ( |
|
|
||
| describe("escrow", () => { | ||
| const provider = anchor.Provider.env(); | ||
| anchor.setProvider(provider); | ||
|
|
||
| const program = anchor.workspace.Escrow; | ||
| const program = anchor.workspace.Escrow as anchor.Program<EscrowIDL>; |
There was a problem hiding this comment.
Hmm the account namespace doesn't type check. I can do program.account.notAValidType and it compiles.
There was a problem hiding this comment.
Is this expected @macalinao or did I miss something.
There was a problem hiding this comment.
I may have forgotten to add this in
There was a problem hiding this comment.
I fixed this by tweaking the AccountNamespace. But for this to work, I also needed to customize the script that produces the idl type such that the Account names are camel case.
I think we'd want to think through the dev flow for producing the IDL type definition if we are to ship this. Maybe we add a script to anchor-cli that produces the IDL types for you?
There was a problem hiding this comment.
Putting this on your radar @armaniferrante
There was a problem hiding this comment.
Is this ready for another review/testing?
|
To anyone here: I've published a package here: https://github.com/saber-hq/saber-common/tree/master/packages/anchor-contrib This contains most of these types. It's undocumented but feel free to ping me on Telegram (@imacalinao) if you're using it! |
|
@macalinao Great work on this PR! What needs to happen to kick it across the line? I'm ready to help out where needed |
@crispheaney is this WIP still or is it ready to go for another round of testing? |
I fixed the Before we merge this in, I think we'd want to define the dev flow for taking their target's IDL and transforming it the IDL type. I made a hacky script that does this. |
As someone consuming this, I think the hacky way is fine. Not everyone will want their types in the same place, I wrote our own custom script because we have a lerna setup and I want the generated code in its respective package. I think documenting it well would suffice for now, then automate later. |
| [K in T[number]["name"]]: TypeDef<T[number] & { name: K }, Defined>; | ||
| }; | ||
|
|
||
| export type IdlTypes<T extends Idl> = TypeDefDictionary< |
There was a problem hiding this comment.
Also useful to add and export:
export type IdlAccounts<T extends Idl> = TypeDefDictionary<
NonNullable<T["accounts"]>,
Record<string, never>
>;
|
This has a bunch of conflicts now, I'm going to create a separate PR since I did the merge. #795 |
|
@armaniferrante can this be closed? |
|
Yeh, this seems like a dead PR. Please use anchor typescript or anchor-client-gen for a static typescript client. |
No description provided.