Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter JS change frameRate constraints #286

Closed
siraj1044 opened this issue Jun 2, 2017 · 4 comments
Closed

Adapter JS change frameRate constraints #286

siraj1044 opened this issue Jun 2, 2017 · 4 comments
Assignees
Labels
getUserMedia webrtc-adapter webrtc-adapter related
Milestone

Comments

@siraj1044
Copy link

When using iosrtc with adapter js it changes frameRate constraint from
video:{ frameRate:{ min: 10.0, max: 15.0 } }
To
video:{ mandatory:{ minframeRate: 10.0, maxframeRate: 15.0 } }

Is it something to be handled on iosrtc plugin or is there another way to do it?

Thanks

@hthetiot hthetiot added webrtc-adapter webrtc-adapter related getUserMedia labels Aug 14, 2019
@hthetiot hthetiot added this to the 5.0.x milestone Sep 13, 2019
@hthetiot hthetiot self-assigned this Sep 13, 2019
@hthetiot
Copy link
Contributor

hthetiot commented Sep 13, 2019

see WIP #399

@hthetiot
Copy link
Contributor

hthetiot commented Oct 6, 2019

@hthetiot
Copy link
Contributor

webrtc-adater does

video:{ mandatory:{ minFrameRate: 10.0, maxFrameRate: 15.0 } }

NOT (lower case f):

video:{ mandatory:{ minframeRate: 10.0, maxframeRate: 15.0 } }

@hthetiot
Copy link
Contributor

Fixed here ed59cdc and also on master here 621e88e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
getUserMedia webrtc-adapter webrtc-adapter related
Projects
None yet
Development

No branches or pull requests

2 participants