Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to version 1.6.9 #3773

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Bump to version 1.6.9 #3773

merged 1 commit into from
Mar 24, 2020

Conversation

miekg
Copy link
Member

@miekg miekg commented Mar 24, 2020

See #3727 for the details. Copying release notes
verbatim to coredns-1.6.9.md and fix the release script (because
Makefiles are stupid). Up version to 1.6.9 here as well.

Copy link
Member

@stp-ip stp-ip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Makefile.release Outdated Show resolved Hide resolved
Makefile.release Outdated Show resolved Hide resolved
@stp-ip
Copy link
Member

stp-ip commented Mar 24, 2020

Gotta love github not adhering to DCO 🤦‍♂️

@miekg
Copy link
Member Author

miekg commented Mar 24, 2020

Gotta love github not adhering to DCO

Let me squash - ffs

See #3727 for the details. Copying release notes
verbatim to coredns-1.6.9.md and fix the release script (because
Makefile are stupid). Up version to 1.6.9 here as well.

Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg miekg force-pushed the fix-release-1.6.9 branch from ad6b6ec to b197ff0 Compare March 24, 2020 15:22
@stp-ip
Copy link
Member

stp-ip commented Mar 24, 2020

/lgtm

Copy link

@corbot corbot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by stp-ip

@miekg
Copy link
Member Author

miekg commented Mar 24, 2020

hmm, maybe the DCO bot needs to know about Co-Authored-By ?

@miekg miekg merged commit 1766568 into master Mar 24, 2020
@miekg miekg deleted the fix-release-1.6.9 branch March 24, 2020 15:26
@stp-ip
Copy link
Member

stp-ip commented Mar 24, 2020

Related issue: dcoapp/app#102
Seems like it's stale feature request.

nyodas pushed a commit to DataDog/coredns that referenced this pull request Oct 26, 2020
See coredns#3727 for the details. Copying release notes
verbatim to coredns-1.6.9.md and fix the release script (because
Makefile are stupid). Up version to 1.6.9 here as well.

Signed-off-by: Miek Gieben <miek@miek.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants