-
Notifications
You must be signed in to change notification settings - Fork 157
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
overlay/fcos: pin legacy ifnames on existing machines
This introduces a `coreos-keep-legacy-ifnames` service to pin network interface names to the legacy scheme on machines where `99-default.link` is missing. This is in order to ensure that those machines do not jump into the new scheme via auto-updates as soon as FCOS starts shipping such unit in the OS.
- Loading branch information
Showing
3 changed files
with
53 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
overlay.d/15fcos/usr/lib/systemd/system/coreos-keep-legacy-ifnames.service
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
[Unit] | ||
Description=CoreOS Keep Legacy Network Interface Names | ||
Documentation=https://github.com/coreos/fedora-coreos-tracker/issues/484 | ||
RequiresMountsFor=/boot | ||
ConditionPathExists=!/usr/lib/systemd/network/99-default.link | ||
# NOTE: we do not conditionalize on ConditionKernelCommandLine= here because | ||
# kernel args might have been tweaked manually just for this boot; we still | ||
# want to change the BLS entries in that case. | ||
|
||
[Service] | ||
Type=oneshot | ||
RemainAfterExit=yes | ||
ExecStart=/usr/libexec/coreos-keep-legacy-ifnames | ||
|
||
[Install] | ||
WantedBy=multi-user.target |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
#!/bin/bash | ||
# This is a pinning script to keep legacy ifnames on machines that were | ||
# installed on an OS version where `99-default.link` was missing due to | ||
# https://github.com/coreos/fedora-coreos-tracker/issues/484 | ||
|
||
set -euo pipefail | ||
|
||
injected=0 | ||
|
||
if test -e /usr/lib/systemd/network/99-default.link; then | ||
echo "unit /usr/lib/systemd/network/99-default.link found, no actions performed" | ||
exit 0; | ||
fi | ||
|
||
for f in /boot/loader/entries/*.conf; do | ||
options=$(grep '^options ' "$f" | cut -f2- -d' ') | ||
|
||
# If it is already specified, do not touch whatever value is there. | ||
# This is in order to avoid messing with user customization, and to | ||
# makes the logic idempotent. | ||
if grep -q "net.ifnames" <<< "$options"; then | ||
continue | ||
fi | ||
|
||
# Otherwise, make sure we stay on legacy ifnames. | ||
sed -e "/^options / s/$/ net.ifnames=0/" -i "$f" | ||
echo "$(basename "$f"): injected net.ifnames=0" | ||
injected=1 | ||
done | ||
|
||
if [[ $injected -eq 0 ]]; then | ||
echo "existing ifnames kargs detected, no actions performed" | ||
fi | ||
|