-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add CLHM helper to warn about modularity on F39 systems #2510
add CLHM helper to warn about modularity on F39 systems #2510
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's notable that there's nothing CoreOS specific about this actually. Having a warning on the console won't be very visible to desktop users e.g.
One minor downside is that now every single boot for all CoreOS systems, including those not using modularity (client side) will have to spend CPU cycles on this.
Combining these two things: the check would perhaps be better implemented in rpm-ostree; we could write out a journal message when we detect this with a dedicated MESSAGE_ID, and then clients (such as CLHM but also gnome-software etc.) could scrape it if present. In that case we only do the check if rpm-ostree is already being invoked, note.
Anyways, I'm OK with this.
True, though non-CoreOS users (I think) typically upgrade interactively and thus can evaluate problems at the time of attempted upgrade, which makes the warning less necessary IMO.
Indeed. The way I've implemented this PR means it only gets applied until we switch to F39, which means it's timeboxed.
Yeah. I guess this cross cuts with us maybe removing modularity support from rpm-ostree too. For this I was trying not to require work being done in other components since it was easy enough for us to just check with a single CLI call.
+1 - I'm happy for this to happen at another level if a better solution emerges. |
Some questions I had and thoughts intermixed:
So overall, I'm inclined to say that this should be OK as it's limited in time and we probably don't want to invest development time in rpm-ostree for that given that we'll potentially remove all the code for modules support once F39 comes. Maybe if we send a message about the modularity support drop on coreos-status we can also include a note for non-modularity users to mask this unit to avoid taking the I/O hit? F39 release is in october so about 3 months away. |
I don't know of other OSTree variants that use CLHM. Does IoT? I don't Silverblue does. The unit works now I just copied coreos-check-cgroups example that's already in our code base.
The unit currently writes to The warning that is printed today instructs the user how to disable the warning from being displayed again.
That seems reasonable. Though really, it's one unit on boot. It doesn't run more than once a boot. Is
|
I think we're the only ostree variant using it. IoT does not: https://pagure.io/fedora-iot/ostree/blob/main/f/fedora-iot-base.json
👍🏻 |
See coreos/fedora-coreos-tracker#1513