don't delete commit meta data when pruning

[dustymabe]

It would be nice if we didn't lose a paper trail when pruning old commits. When I try to do an infinite pull of information from rawhide I see:

[vagrant@vanilla-f26atomic ~]$ ostree --repo=/tmp/ostreerepo-rawhide/ pull --commit-metadata-only --depth=-1 remote-rawhide:fedora/rawhide/x86_64/atomic-host                                                     

17 metadata, 0 content objects fetched; 1 KiB transferred in 2 seconds                                                                                                                                            
[vagrant@vanilla-f26atomic ~]$ ostree --repo=/tmp/ostreerepo-rawhide/ log fedora/rawhide/x86_64/atomic-host
commit 2c342c577dc072f132663195c522a91daa5482b956422494ea7ba6c9b6482832
Date:  2017-06-21 14:08:49 +0000
Version: Rawhide.20170621.n.0
(no subject)

commit 36e540a2dda2fd9c49b2c5e90d942f72b7db88133f9f2f4ec566dac43d5ed752
Date:  2017-06-20 19:41:58 +0000
Version: Rawhide.20170620.n.0
(no subject)

commit d3028d22ef075a4ad27c5b8af6ebf353784d10d8a777e25ac32775852f59595a
Date:  2017-06-19 11:03:05 +0000
Version: Rawhide.20170619.n.0
(no subject)

commit 4631fc0ad86731a2170137dd7d3f1711595f947b12044b99820e95b9abbc2bd4
Date:  2017-06-18 10:39:27 +0000
Version: Rawhide.20170618.n.0
(no subject)

commit 22b44e21ee150a0c95f4297fed05e2b98f9a1463ec11b6fc1516538a7c2ba35e
Date:  2017-06-17 10:56:43 +0000
Version: Rawhide.20170617.n.0
(no subject)

commit e739881a8d7be0e0065f9870d650de0e73cb25abd5b0106f070bb51dd9f383dc
Date:  2017-06-16 10:57:00 +0000
Version: Rawhide.20170616.n.0
(no subject)

commit c53b044e715b439d6c77e210581862b77c243fc70b53f307088529248975de07
Date:  2017-06-15 11:12:20 +0000
Version: Rawhide.20170615.n.0
(no subject)

commit 3073e0d65fb4244ca3e44c7f34c241055152a0ed1b8167d1f5eaf5c35c19fb2d
Date:  2017-06-15 04:32:23 +0000
Version: Rawhide.20170614.n.0
(no subject)

commit 7e849bac65d90f931a71430d5456903b66e1c8e34cd1fd748e17b57085a85472
Date:  2017-06-14 03:47:05 +0000
Version: Rawhide.20170613.n.1
(no subject)

commit a7f48fc975813e4293adc4c480c59ccb27e2d9d5e3a44acb6978843d182b3307
Date:  2017-06-13 14:27:37 +0000
Version: Rawhide.20170613.n.0
(no subject)

commit 53fdd1e74a62d29f8726bbe8bfa6c60a5254d173a795f31171a4299d2db5b9c7
Date:  2017-06-12 13:11:51 +0000
Version: Rawhide.20170612.n.0
(no subject)

commit e972a3b99362f8842aa19ff37bba8cff3ae67081dfa10e4bcb0ad7d166435512
Date:  2017-06-11 23:14:55 +0000
Version: Rawhide.20170611.n.1
(no subject)

commit c35d359fb5df5becc0d643ff1206789b61af015b7ec953beb4feb6081195b49f
Date:  2017-06-11 12:00:38 +0000
Version: Rawhide.20170611.n.0
(no subject)

commit cd48dbbc9e6976eec4f9f2d7652f3c794aa597cc80967304f09e0c2614f00ab6
Date:  2017-06-10 12:56:14 +0000
Version: Rawhide.20170610.n.0
(no subject)

<< History beyond this commit not fetched >>

We only get a few weeks of history because we have set to prune the repo after 14 days, which makes sense. It is what we asked for. The part that doesn't make sense is << History beyond this commit not fetched >>, since there is 'no history' any longer for beyond that point. I think it would be better if we actually didn't delete commit metadata by default on prune (make it an non-default option to delete the metadata) and also update the history information to show when a commits objects have been pruned.

If we combine this with #558 then even though we pruned commit objects we would still be able to see what rpms existed in a particular commit through the metadata.

[cgwalters]

This is a pure libostree issue, mind refiling there?

[dustymabe]

This is a pure libostree issue, mind refiling there?

yep - ostreedev/ostree#954