Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm-ostree: do not try to auto-update to local deployments #111

Closed
lucab opened this issue Aug 26, 2019 · 0 comments · Fixed by #112
Closed

rpm-ostree: do not try to auto-update to local deployments #111

lucab opened this issue Aug 26, 2019 · 0 comments · Fixed by #112

Comments

@lucab
Copy link
Contributor

lucab commented Aug 26, 2019

This is a followup to coreos/fedora-coreos-tracker#247.

In case of rollbacks or non-default boots, Zincati will immediately try to re-upgrade to a (possibly bad) locally available deployment. This is because Zincati sees that an update is available in the update-graph, but it doesn't know that it had already tried it and for some reason the system booted back into an earlier deployment.

To avoid this, Zincati should look for deployments already available locally and filter them out from possible targets in the received update-graph. That will avoid immediate auto-updates both in auto-rollback and manual-boot cases.

This will only cover bad deployments as long as they are still locally available on the system. In case of garbage collection of deployments, that piece of history will be gone and Zincati may try again to auto-update into them again. This is fine for the short-term, and in the longer term it would be maybe covered in conjunction with coreos/rpm-ostree#1813.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant