Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made tests more reliable, enabled and fixed some tests #71

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Made tests more reliable, enabled and fixed some tests #71

merged 1 commit into from
Mar 8, 2022

Conversation

theseion
Copy link
Contributor

@theseion theseion commented Mar 8, 2022

Split from #66

@theseion theseion requested review from fgsch and fzipi March 8, 2022 21:30
fzipi
fzipi approved these changes Mar 8, 2022
View reviewed changes
Copy link
Member

@fzipi fzipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fzipi fzipi merged commit 5daacce into coreruleset:main Mar 8, 2022
@theseion theseion deleted the performance-improvement-updated-tests branch March 9, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzipi fzipi fzipi approved these changes

@fgsch fgsch Awaiting requested review from fgsch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theseion @fzipi